Changeset 3096

Timestamp:

Oct 13, 2010 10:32:35 PM (11 years ago)

Author:

jwatson

Message:

Enhancements to PySP to deal with reporting issues caused by the lack of objective function values in SOL files (in general, and those produced by ipopt in particular).

Location:

coopr.pysp/trunk/coopr/pysp

Files:

• ph.py (modified) (1 diff)
• scenariotree.py (modified) (3 diffs)

coopr.pysp/trunk/coopr/pysp/ph.py

@@ -1119 +1119 @@
          # the "value" attribute is a pre-defined feature of any solution - it is relative to whatever
          # objective was selected during optimization, which of course should be the PH objective.
-         ph_objective_values[instance.name] = float(results.solution(0).objective['f'].value)
+         try:
+            ph_objective_values[instance.name] = float(results.solution(0).objective['f'].value)
+         except AttributeError:
+            # some solvers (e.g., through the SOL interface) don't report objective function values.
+            ph_objective_values[instance.name] = 0.0
 
          num_results_so_far = num_results_so_far + 1

coopr.pysp/trunk/coopr/pysp/scenariotree.py

@@ -172 +172 @@
       # IMPT: This implicitly assumes convergence across the scenarios - if not, garbage results.
       instance = scenario_instance_map[self._scenarios[0]._name]
-      my_cost = instance.active_components(Var)[self._stage._cost_variable[0].name][self._stage._cost_variable[1]].value
+      stage_cost_variable = instance.active_components(Var)[self._stage._cost_variable[0].name][self._stage._cost_variable[1]]
+      if stage_cost_variable.value is not None:
+         my_cost = stage_cost_variable.value
+      else:
+         # depending on the situation (and the model), the stage cost variables might not have values.                        
+         my_cost = 0.0
       child_cost = 0.0
       for child in self._children:
@@ -529 +534 @@
       aggregate_cost = 0.0
       for stage in self._stages:
-         instance_cost_variable = instance.active_components(Var)[stage._cost_variable[0].name][stage._cost_variable[1]].value
-         aggregate_cost += instance_cost_variable
+            instance_cost_variable = instance.active_components(Var)[stage._cost_variable[0].name][stage._cost_variable[1]]
+            if instance_cost_variable.value is not None:
+                # depending on the situation (and the model), the stage cost variables might not have values.               
+               aggregate_cost += instance_cost_variable
       return aggregate_cost
 
@@ -951 +958 @@
          aggregate_cost = 0.0
          for stage in self._stages:
-            instance_cost_variable = instance.active_components(Var)[stage._cost_variable[0].name][stage._cost_variable[1]].value
-            print "\tStage=%20s     Cost=%10.4f" % (stage._name, instance_cost_variable)
-            aggregate_cost += instance_cost_variable
+            instance_cost_variable = instance.active_components(Var)[stage._cost_variable[0].name][stage._cost_variable[1]]
+            if instance_cost_variable.value is not None:
+               print "\tStage=%20s     Cost=%10.4f" % (stage._name, instance_cost_variable.value)
+               cost = instance_cost_variable.value
+            else:
+               print "\tStage=%20s     Cost=%10s" % (stage._name, "Not Rprted.")
+               cost = 0.0
+            aggregate_cost += cost
          print "\tTotal scenario cost=%10.4f" % aggregate_cost
          print ""