Ignore:
Timestamp:
Nov 2, 2011 11:25:47 AM (8 years ago)
Author:
mjs
Message:

Eclipse code analyzer recommendations: (a) catch exceptions by reference; (b) parenthesize multi-term Boolean expressions; (c) virtual methods need virtual dtors (and Eclipse likes to see the keyword); (d) operator=() should return *this (and check for self-assignment).

File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/ClpForOsi2/Clp/test/OsiClpSolverInterfaceTest.cpp

    r1745 r1816  
    143143        OSIUNITTEST_ADD_OUTCOME("clp", "setObjCoeff on empty model", "should throw exception", OsiUnitTest::TestOutcome::ERROR, false);
    144144      }
    145       catch (CoinError e) {
     145      catch (CoinError& e) {
    146146        if (OsiUnitTest::verbosity >= 1)
    147147          std::cout<<"Correct throw from setObjCoeff on empty model"<<std::endl;
     
    158158        OSIUNITTEST_ADD_OUTCOME("clp", "setColSetBounds on cols not in model", "should throw exception", OsiUnitTest::TestOutcome::ERROR, false);
    159159      }
    160       catch (CoinError e) {
     160      catch (CoinError& e) {
    161161        if (OsiUnitTest::verbosity >= 1)
    162162          std::cout<<"Correct throw from setObjCoeff on empty model"<<std::endl;
Note: See TracChangeset for help on using the changeset viewer.