Opened 11 years ago

Closed 8 years ago

#68 closed defect (fixed)

User-given FFLAGS ignored for dlamch compilation

Reported by: andreasw Owned by: andreasw
Priority: major Component: configuration tests
Version: 0.5 Keywords:
Cc:

Description

Hi Stefan :-)

The compilation of dlamch still has some problems. For example, if someone sets FFLAGS, this is completely ignored when compiling it. (In an IBM context, someone had -fPIC included in FFLAGS and uses --disable-shared, so this doesn't work when you later try to make a shared library)

Instead of setting it to the coin_warn_flags etc, would it make more sense to scan the content of FFLAGS and remove anything of the form '-O*' and replace it by '-O0'? Not sure if that works for all compilers though (Windoofs?). At the very least, we should make DLAMCH_FFLAGS an argument that one can set.

What do you think?

Andreas

Change History (2)

comment:1 Changed 11 years ago by stefan

Hi,

you are right, FFLAGS should not be ignored. I just committed https://projects.coin-or.org/BuildTools/changeset/1178#file1

  1. I tried to simplify it. Now it just adds -O0 or -Od to the end of FFLAGS. If compilers read from left to right, than this flag should overwrite a possible -O* from the OPT_FFLAGS, and if it is already in debug mode, then it should not harm.
  1. You can set DLAMCH_FFLAGS from outside now.

You think this will work? :-)

Stefan

comment:2 Changed 8 years ago by stefan

  • Resolution set to fixed
  • Status changed from new to closed

No reply from submitter for 2 years, so I believe the fix works.

Note: See TracTickets for help on using tickets.